Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Refactor MultiFactor.swift #14241

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Auth] Refactor MultiFactor.swift #14241

wants to merge 2 commits into from

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 10, 2024 •
edited
Loading

Manual tests:

  • Phone MFA login
  • TOTP MFA login
  • ?

#no-changelog

paulb777
paulb777 reviewed Dec 11, 2024
View reviewed changes
FirebaseAuth/Sources/Swift/MultiFactor/MultiFactor.swift

guard
assertion.factorID == PhoneMultiFactorInfo.TOTPMultiFactorID ||
assertion.factorID == PhoneMultiFactorInfo.TOTPMultiFactorID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or of the same value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @paulb777 @google-oss-bot